Detect exceptions raised outside of the handler - #475
Merged
Conversation
TalUsvyatsky
force-pushed
the
tal.usvyatsky/capture-handler-import-failure
branch
8 times, most recently
from
April 23, 2024 14:17
80486fd to
76e5cee
Compare
TalUsvyatsky
marked this pull request as ready for review
April 23, 2024 14:32
duncanista
reviewed
Apr 23, 2024
duncanista
reviewed
Apr 23, 2024
duncanista
reviewed
Apr 23, 2024
TalUsvyatsky
force-pushed
the
tal.usvyatsky/capture-handler-import-failure
branch
from
April 23, 2024 19:00
85d0d7d to
0bc08fd
Compare
Contributor
|
FYI, pulling from main should fix the check layer size test failure. |
purple4reina
approved these changes
Apr 23, 2024
TalUsvyatsky
force-pushed
the
tal.usvyatsky/capture-handler-import-failure
branch
from
April 24, 2024 13:32
39af365 to
f0e8c5e
Compare
duncanista
approved these changes
Apr 24, 2024
duncanista
left a comment
Contributor
There was a problem hiding this comment.
Amazing work – LGTM.
There's one nit:
datadog-lambda-python/datadog_lambda/tracing.py
Lines 1236 to 1255 in 21012cb
Should we care about some of the tags that can be added from this? i.e. functionname, cold_start (which should always be true if we are loading), datadog_lambda_version, ddtrace_version
TalUsvyatsky
force-pushed
the
tal.usvyatsky/capture-handler-import-failure
branch
2 times, most recently
from
April 29, 2024 17:16
26ed616 to
47c0dab
Compare
purple4reina
approved these changes
Apr 29, 2024
…d outside of the handler function
Co-authored-by: jordan gonzález <30836115+duncanista@users.noreply.github.com>
TalUsvyatsky
force-pushed
the
tal.usvyatsky/capture-handler-import-failure
branch
from
May 1, 2024 13:55
f6a8496 to
7c5aa58
Compare
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds telemetry for exceptions that occur outside of the handler function.
When an exception occurs outside of the handler function:
aws.lambda.enhanced.errorsis emittedMotivation
Testing Guidelines
aws.lambda.enhanced.errorsemitted (graph)Additional Notes
Types of Changes
Check all that apply
https://datadoghq.atlassian.net/browse/SVLS-4666