fix(50224): Intellisense for strings within a type's Union doesn't work properly for JSX - #50231
Merged
Nathan Shively-Sanders (sandersn) merged 2 commits intoAug 23, 2022
Merged
Conversation
TypeScript Bot (typescript-bot)
added
the
For Backlog Bug
Nathan Shively-Sanders (sandersn)
requested changes
Aug 18, 2022
Nathan Shively-Sanders (sandersn)
requested a review
from Gabriela Araujo Britto (gabritto)
August 18, 2022 19:12
Oleksandr Tarasiuk (a-tarasyuk)
requested review from
Nathan Shively-Sanders (sandersn)
and removed request for
Gabriela Araujo Britto (gabritto)
August 18, 2022 19:30
Contributor
Author
|
Surprisingly, when I re-requested a review from Nathan Shively-Sanders (@sandersn), Github removed Gabriela Araujo Britto (@gabritto) from the reviewers 😟 |
Nathan Shively-Sanders (sandersn)
requested a review
from Gabriela Araujo Britto (gabritto)
August 23, 2022 21:56
Nathan Shively-Sanders (sandersn)
approved these changes
Aug 23, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #50224