Remove AUTHORS.md, .mailmap, authors.ts script - #50410
Merged
Jake Bailey (jakebailey) merged 4 commits intoAug 25, 2022
Merged
Conversation
Jake Bailey (jakebailey)
requested review from
Daniel Rosenwasser (DanielRosenwasser) and
Ryan Cavanaugh (RyanCavanaugh)
August 23, 2022 00:26
TypeScript Bot (typescript-bot)
added
Author: Team
For Uncommitted Bug
Kashif Ahmed (ProKashif)
approved these changes
Aug 23, 2022
Daniel Rosenwasser (DanielRosenwasser)
approved these changes
Aug 25, 2022
| scripts/word2md.js | ||
| scripts/buildProtocol.js | ||
| scripts/ior.js | ||
| scripts/authors.js |
Member
Author
There was a problem hiding this comment.
Maybe I should just leave this for a bit, until people have cleaned their script dirs enough for it to not be an annoyance.
Member
Author
There was a problem hiding this comment.
Nah, I have already done similar for other files. It'll be clear if some random file sneaks into a PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.mailmaphasn't been updated in 4 years;AUTHORS.mdis generated from.mailmapviaauthors.ts, and has only been edited twice in the past 4 years, once to make it generated, and another to add another name (but, without modifying.mailmap, oops).As far as I can tell, we don't actually need this for any requirement, and its current state seems to imply we don't need it.
TODO: remove mention from https://github.com/microsoft/TypeScript/wiki/Release-Activities#release