Add rules from eslint's recommended set that triggered good lints - #50422
Merged
Jake Bailey (jakebailey) merged 9 commits intoSep 19, 2022
Conversation
TypeScript Bot (typescript-bot)
added
Author: Team
For Uncommitted Bug
| "parser": "@typescript-eslint/parser", | ||
| "parserOptions": { | ||
| "warnOnUnsupportedTypeScriptVersion": false, | ||
| "ecmaVersion": 6, |
Member
Author
There was a problem hiding this comment.
We don't need to set this; the default of "latest" is fine because we compile our source and any new syntax will be downleveled. No need to make eslint complain about it.
Member
Author
|
TypeScript Bot (@typescript-bot) perf test this pretty please |
Contributor
|
Heya Jake Bailey (@jakebailey), I've started to run the perf test suite on this PR at 4650c81. You can monitor the build here. Update: The results are in! |
Contributor
|
Jake Bailey (@jakebailey) Here they are:
CompilerComparison Report - main..50422
System
Hosts
Scenarios
TSServerComparison Report - main..50422
System
Hosts
Scenarios
Developer Information: |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Nathan Shively-Sanders (sandersn)
approved these changes
Sep 13, 2022
| if (container && (container.kind === SyntaxKind.Constructor || isJSConstructor(container))) { | ||
| return container as ConstructorDeclaration; | ||
| } | ||
| }; |
There was a problem hiding this comment.
❤️ semicolons
| /* @internal */ | ||
| export function computeLineStarts(text: string): number[] { | ||
| const result: number[] = new Array(); | ||
| const result: number[] = []; |
There was a problem hiding this comment.
Maybe there was some reason for using new Array here? But performance doesn't seem to have changed.
Member
Author
There was a problem hiding this comment.
I don't think so. It's been there since the first commit of the TypeScript compiler.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Out of interest, I enabled eslint/tseslint's recommended sets. These rules were ones that fired in our repo with standout results that I believe are good changes in the repo.