Fix typechecking related lints that changed post 4.8, update LKG to 4.8.2 - #50472
Merged
Jake Bailey (jakebailey) merged 3 commits intoAug 26, 2022
Merged
Conversation
TypeScript Bot (typescript-bot)
added
Author: Team
For Uncommitted Bug
Jake Bailey (jakebailey)
changed the title
Jake Bailey (jakebailey)
marked this pull request as ready for review
August 26, 2022 17:22
Member
Author
|
I've done something slightly different than normal; I ran: This pulls in the current stable release as our LKG, rather than pulling in what's in |
Jake Bailey (jakebailey)
requested review from
Daniel Rosenwasser (DanielRosenwasser) and
Ryan Cavanaugh (RyanCavanaugh)
August 26, 2022 17:23
Member
Author
|
This does beg the question, though; should our own workspace version of TS be pinned to a specific version? That way, we can make changes in step with npm and LKG? |
| @@ -2973,7 +2973,7 @@ namespace ts { | |||
| function parseDelimitedList<T extends Node | undefined>(kind: ParsingContext, parseElement: () => T, considerSemicolonAsDelimiter?: boolean): NodeArray<NonNullable<T>> | undefined { | |||
Member
Author
There was a problem hiding this comment.
IMO these two fixes should really have T extends Node, then refer to T | undefined, but, this is the more minimal fix.
Daniel Rosenwasser (DanielRosenwasser)
approved these changes
Aug 26, 2022
Gabriela Araujo Britto (gabritto)
approved these changes
Aug 26, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
0715791 updated our workspace TS to 4.8, which changed which TS that ESLint used. These two cases are type assertions that aren't needed anymore in 4.8 with the new narrowing tweaks.
This PR will fail to build because our LKG is too old; I will update the PR with that shortly (I just wanted to see the CI fail). EDIT: Updated.