Allow `{}` to narrow in same special cases as `unknown` by andrewbranch · Pull Request #50601 · microsoft/TypeScript

Andrew Branch (andrewbranch) · 2022-09-02T00:19:32Z

Andrew Branch (andrewbranch) · 2022-09-02T00:20:05Z

TypeScript Bot (@typescript-bot) user test this inline
TypeScript Bot (@typescript-bot) perf test this faster
TypeScript Bot (@typescript-bot) run dt
TypeScript Bot (@typescript-bot) test top100

TypeScript Bot (typescript-bot) · 2022-09-02T00:20:08Z

Heya Andrew Branch (@andrewbranch), I've started to run the parallelized Definitely Typed test suite on this PR at 8fa47f1. You can monitor the build here.

TypeScript Bot (typescript-bot) · 2022-09-02T00:20:08Z

Heya Andrew Branch (@andrewbranch), I'm starting to run the diff-based user code test suite on this PR at 8fa47f1. Hold tight - I'll update this comment with the log link once the build has been queued.

Update: The results are in!

TypeScript Bot (typescript-bot) · 2022-09-02T00:20:08Z

Heya Andrew Branch (@andrewbranch), I've started to run the abridged perf test suite on this PR at 8fa47f1. You can monitor the build here.

Update: The results are in!

TypeScript Bot (typescript-bot) · 2022-09-02T00:20:08Z

Heya Andrew Branch (@andrewbranch), I'm starting to run the diff-based user code test suite on this PR at 8fa47f1. Hold tight - I'll update this comment with the log link once the build has been queued.

Update: The results are in!

TypeScript Bot (typescript-bot) · 2022-09-02T00:33:07Z

Andrew Branch (@andrewbranch) Here are the results of running the user test suite comparing main and refs/pull/50601/merge:

Everything looks good!

TypeScript Bot (typescript-bot) · 2022-09-02T00:59:27Z

Andrew Branch (@andrewbranch)
The results of the perf run you requested are in!

Here they are:

Comparison Report - main..50601

_Metric	_main	₅₀₆₀₁	_Delta	_Best	_Worst
_{Angular - node (v14.15.1, x64)}
_{Memory used}	_{338,735k (± 0.00%)}	_{338,725k (± 0.01%)}	_{-10k (- 0.00%)}	_338,697k	_338,791k
_{Parse Time}	_{2.06s (± 0.74%)}	_{2.08s (± 1.01%)}	_{+0.02s (+ 0.92%)}	_2.03s	_2.12s
_{Bind Time}	_{0.80s (± 0.46%)}	_{0.80s (± 0.62%)}	_{0.00s ( 0.00%)}	_0.79s	_0.81s
_{Check Time}	_{5.83s (± 0.63%)}	_{5.84s (± 0.58%)}	_{+0.02s (+ 0.31%)}	_5.77s	_5.90s
_{Emit Time}	_{6.23s (± 0.78%)}	_{6.16s (± 0.59%)}	_{-0.07s (- 1.19%)}	_6.09s	_6.25s
_{Total Time}	_{14.90s (± 0.48%)}	_{14.87s (± 0.36%)}	_{-0.03s (- 0.22%)}	_14.75s	_14.99s
_{Compiler-Unions - node (v14.15.1, x64)}
_{Memory used}	_{192,628k (± 0.01%)}	_{192,533k (± 0.12%)}	_{-95k (- 0.05%)}	_191,595k	_192,720k
_{Parse Time}	_{0.85s (± 0.58%)}	_{0.85s (± 0.56%)}	_{-0.00s (- 0.23%)}	_0.85s	_0.87s
_{Bind Time}	_{0.49s (± 1.06%)}	_{0.49s (± 1.33%)}	_{-0.00s (- 0.20%)}	_0.48s	_0.51s
_{Check Time}	_{6.72s (± 0.43%)}	_{6.72s (± 0.60%)}	_{+0.00s (+ 0.06%)}	_6.65s	_6.81s
_{Emit Time}	_{2.42s (± 1.40%)}	_{2.42s (± 1.14%)}	_{-0.01s (- 0.37%)}	_2.37s	_2.47s
_{Total Time}	_{10.48s (± 0.40%)}	_{10.48s (± 0.60%)}	_{-0.01s (- 0.07%)}	_10.36s	_10.62s
_{Monaco - node (v14.15.1, x64)}
_{Memory used}	_{326,525k (± 0.00%)}	_{326,518k (± 0.01%)}	_{-7k (- 0.00%)}	_326,482k	_326,558k
_{Parse Time}	_{1.58s (± 0.63%)}	_{1.57s (± 0.82%)}	_{-0.01s (- 0.44%)}	_1.55s	_1.61s
_{Bind Time}	_{0.73s (± 0.50%)}	_{0.72s (± 0.62%)}	_{-0.00s (- 0.55%)}	_0.71s	_0.73s
_{Check Time}	_{5.73s (± 0.26%)}	_{5.69s (± 0.56%)}	_{-0.04s (- 0.73%)}	_5.63s	_5.75s
_{Emit Time}	_{3.32s (± 0.43%)}	_{3.33s (± 0.73%)}	_{+0.01s (+ 0.18%)}	_3.27s	_3.39s
_{Total Time}	_{11.36s (± 0.22%)}	_{11.31s (± 0.45%)}	_{-0.05s (- 0.41%)}	_11.21s	_11.44s
_{TFS - node (v14.15.1, x64)}
_{Memory used}	_{289,655k (± 0.01%)}	_{289,657k (± 0.01%)}	_{+2k (+ 0.00%)}	_289,599k	_289,687k
_{Parse Time}	_{1.30s (± 0.77%)}	_{1.30s (± 0.51%)}	_{+0.00s (+ 0.23%)}	_1.29s	_1.32s
_{Bind Time}	_{0.79s (± 1.27%)}	_{0.79s (± 0.66%)}	_{+0.00s (+ 0.51%)}	_0.78s	_0.81s
_{Check Time}	_{5.35s (± 0.43%)}	_{5.36s (± 0.39%)}	_{+0.01s (+ 0.15%)}	_5.33s	_5.42s
_{Emit Time}	_{3.56s (± 0.49%)}	_{3.58s (± 0.91%)}	_{+0.03s (+ 0.73%)}	_3.53s	_3.67s
_{Total Time}	_{11.00s (± 0.36%)}	_{11.04s (± 0.41%)}	_{+0.04s (+ 0.41%)}	_10.95s	_11.14s
_{material-ui - node (v14.15.1, x64)}
_{Memory used}	_{436,470k (± 0.00%)}	_{436,476k (± 0.00%)}	_{+5k (+ 0.00%)}	_436,434k	_436,527k
_{Parse Time}	_{1.87s (± 0.54%)}	_{1.86s (± 0.48%)}	_{-0.00s (- 0.05%)}	_1.85s	_1.89s
_{Bind Time}	_{0.58s (± 0.58%)}	_{0.58s (± 0.69%)}	_{-0.00s (- 0.34%)}	_0.57s	_0.59s
_{Check Time}	_{12.85s (± 0.61%)}	_{12.89s (± 0.70%)}	_{+0.04s (+ 0.30%)}	_12.72s	_13.17s
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_{0.00s ( NaN%)}	_0.00s	_0.00s
_{Total Time}	_{15.30s (± 0.51%)}	_{15.33s (± 0.61%)}	_{+0.03s (+ 0.20%)}	_15.16s	_15.62s
_{xstate - node (v14.15.1, x64)}
_{Memory used}	_{546,740k (± 0.00%)}	_{546,735k (± 0.00%)}	_{-5k (- 0.00%)}	_546,711k	_546,761k
_{Parse Time}	_{2.61s (± 0.56%)}	_{2.60s (± 0.40%)}	_{-0.01s (- 0.23%)}	_2.58s	_2.63s
_{Bind Time}	_{0.97s (± 0.70%)}	_{0.97s (± 0.78%)}	_{+0.00s (+ 0.10%)}	_0.96s	_0.99s
_{Check Time}	_{1.52s (± 0.76%)}	_{1.52s (± 0.37%)}	_{-0.00s (- 0.20%)}	_1.51s	_1.53s
_{Emit Time}	_{0.07s (± 0.00%)}	_{0.07s (± 4.13%)}	_{+0.00s (+ 2.86%)}	_0.07s	_0.08s
_{Total Time}	_{5.18s (± 0.49%)}	_{5.17s (± 0.36%)}	_{-0.01s (- 0.17%)}	_5.12s	_5.21s

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 4.4.0-210-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{15 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v14.15.1, x64)

Scenarios

Angular - node (v14.15.1, x64)
Compiler-Unions - node (v14.15.1, x64)
Monaco - node (v14.15.1, x64)
TFS - node (v14.15.1, x64)
material-ui - node (v14.15.1, x64)
xstate - node (v14.15.1, x64)

_Benchmark	_Name	_Iterations
_Current	₅₀₆₀₁	₁₀
_Baseline	_main	₁₀

Developer Information:

Download Benchmark

TypeScript Bot (typescript-bot) · 2022-09-02T02:03:00Z

Andrew Branch (@andrewbranch) Here are the results of running the top-repos suite comparing main and refs/pull/50601/merge:

Everything looks good!

Andrew Branch (andrewbranch) · 2022-09-02T16:41:31Z

TypeScript Bot (@typescript-bot) cherry-pick to release-4.8

TypeScript Bot (typescript-bot) · 2022-09-02T16:41:34Z

Heya Andrew Branch (@andrewbranch), I've started to run the task to cherry-pick this into release-4.8 on this PR at 8fa47f1. You can monitor the build here.

TypeScript Bot (typescript-bot) · 2022-09-02T16:46:41Z

Hey Andrew Branch (@andrewbranch), I've opened #50613 for you.

Component commits: 8fa47f1 Allow `{}` to narrow in same special cases as `unknown`

Component commits: 8fa47f1 Allow `{}` to narrow in same special cases as `unknown` Co-authored-by: Andrew Branch <andrew@wheream.io>

Allow {} to narrow in same special cases as unknown

8fa47f1

Andrew Branch (andrewbranch) marked this pull request as ready for review September 2, 2022 00:19

TypeScript Bot (typescript-bot) assigned Andrew Branch (andrewbranch) Sep 2, 2022

TypeScript Bot (typescript-bot) added Author: Team For Milestone Bug PRs that fix a bug with a specific milestone labels Sep 2, 2022

Andrew Branch (andrewbranch) requested a review from Anders Hejlsberg (ahejlsberg) September 2, 2022 00:19

Anders Hejlsberg (ahejlsberg) approved these changes Sep 2, 2022

View reviewed changes

TypeScript Bot (typescript-bot) mentioned this pull request Sep 2, 2022

🤖 Pick PR #50601 (Allow {} to narrow in same specia...) into release-4.8 #50613

Merged

TypeScript Bot (typescript-bot) pushed a commit to typescript-bot/TypeScript that referenced this pull request Sep 2, 2022

Cherry-pick PR microsoft#50601 into release-4.8

4c302f6

Component commits: 8fa47f1 Allow `{}` to narrow in same special cases as `unknown`

Andrew Branch (andrewbranch) added this to the TypeScript 4.8.3 milestone Sep 2, 2022

Andrew Branch (andrewbranch) merged commit 856c7c5 into microsoft:main Sep 2, 2022

Andrew Branch (andrewbranch) deleted the bug/50567 branch September 2, 2022 16:47

Andrew Branch (andrewbranch) added a commit that referenced this pull request Sep 2, 2022

Cherry-pick PR #50601 into release-4.8 (#50613)

451b5ba

Component commits: 8fa47f1 Allow `{}` to narrow in same special cases as `unknown` Co-authored-by: Andrew Branch <andrew@wheream.io>

sync-by-unito Bot mentioned this pull request Sep 13, 2022

build(deps-dev): bump typescript from 4.6.4 to 4.8.3 numbersprotocol/capture-cam#2065

Closed

Microsoft (microsoft) locked as resolved and limited conversation to collaborators Oct 22, 2025

Navigation Menu

Uh oh!

Allow `{}` to narrow in same special cases as `unknown` - #50601

Allow `{}` to narrow in same special cases as `unknown`#50601
Andrew Branch (andrewbranch) merged 1 commit into
microsoft:mainfrom
andrewbranch:bug/50567

Andrew Branch (andrewbranch) commented Sep 2, 2022

Uh oh!

Andrew Branch (andrewbranch) commented Sep 2, 2022

Uh oh!

TypeScript Bot (typescript-bot) commented Sep 2, 2022 •

edited

Loading

Uh oh!

TypeScript Bot (typescript-bot) commented Sep 2, 2022 •

edited

Loading

Uh oh!

TypeScript Bot (typescript-bot) commented Sep 2, 2022 •

edited

Loading

Uh oh!

TypeScript Bot (typescript-bot) commented Sep 2, 2022 •

edited

Loading

Uh oh!

TypeScript Bot (typescript-bot) commented Sep 2, 2022

Uh oh!

TypeScript Bot (typescript-bot) commented Sep 2, 2022

Uh oh!

TypeScript Bot (typescript-bot) commented Sep 2, 2022

Uh oh!

Andrew Branch (andrewbranch) commented Sep 2, 2022

Uh oh!

TypeScript Bot (typescript-bot) commented Sep 2, 2022 •

edited

Loading

Uh oh!

TypeScript Bot (typescript-bot) commented Sep 2, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

Andrew Branch (andrewbranch) commented Sep 2, 2022

Uh oh!

Andrew Branch (andrewbranch) commented Sep 2, 2022

Uh oh!

TypeScript Bot (typescript-bot) commented Sep 2, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Sep 2, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Sep 2, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Sep 2, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Sep 2, 2022

Uh oh!

TypeScript Bot (typescript-bot) commented Sep 2, 2022

Uh oh!

TypeScript Bot (typescript-bot) commented Sep 2, 2022

Uh oh!

Andrew Branch (andrewbranch) commented Sep 2, 2022

Uh oh!

TypeScript Bot (typescript-bot) commented Sep 2, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Sep 2, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

TypeScript Bot (typescript-bot) commented Sep 2, 2022 •

edited

Loading

TypeScript Bot (typescript-bot) commented Sep 2, 2022 •

edited

Loading

TypeScript Bot (typescript-bot) commented Sep 2, 2022 •

edited

Loading

TypeScript Bot (typescript-bot) commented Sep 2, 2022 •

edited

Loading

TypeScript Bot (typescript-bot) commented Sep 2, 2022 •

edited

Loading