fix(50717): tsc crashes when it sees a JSDoc tag inside an @override annotation - #50724
Merged
Merged
Conversation
TypeScript Bot (typescript-bot)
added
the
For Uncommitted Bug
Oleksandr Tarasiuk (a-tarasyuk)
force-pushed
the
fix/50717
branch
3 times, most recently
from
September 12, 2022 12:54
0b53188 to
b2d35f4
Compare
Oleksandr Tarasiuk (a-tarasyuk)
force-pushed
the
fix/50717
branch
from
September 12, 2022 12:56
b2d35f4 to
a341042
Compare
Jake Bailey (jakebailey)
requested review from
Andrew Branch (andrewbranch) and
Nathan Shively-Sanders (sandersn)
September 12, 2022 22:00
Member
|
Note that if this is to be backported to 4.8, it'll have to change quite a bit given |
Member
|
As a crash regression, I think we will want to backport this somehow. |
TypeScript Bot (typescript-bot)
added
For Milestone Bug
Jake Bailey (jakebailey)
approved these changes
Sep 13, 2022
Member
|
I'll send a backport PR for 4.8. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #50717