Add more tracing to node16/nodenext resolution - #51168
Merged
Andrew Branch (andrewbranch) merged 4 commits intoOct 14, 2022
Merged
Conversation
Andrew Branch (andrewbranch)
requested a review
from Sheetal Nandi (sheetalkamat)
October 13, 2022 21:53
TypeScript Bot (typescript-bot)
added
Author: Team
For Milestone Bug
Andrew Branch (andrewbranch)
requested a review
from Wesley Wigham (weswigham)
October 13, 2022 21:53
Wesley Wigham (weswigham)
approved these changes
Oct 14, 2022
Wesley Wigham (weswigham)
left a comment
Wesley Wigham (weswigham)
left a comment
Member
There was a problem hiding this comment.
Could maybe also add a trace entry on unmatched condition, since there usually aren't too many, and, if we're honest, entries above ones we do match are usually a mistake.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #51001