fix(51170): Completing an unimplemented property overwrites rest of line - #51175
Merged
Daniel Rosenwasser (DanielRosenwasser) merged 2 commits intoOct 17, 2022
Merged
Conversation
TypeScript Bot (typescript-bot)
added
the
For Milestone Bug
| preferences.includeCompletionsWithInsertText && | ||
| completionKind === CompletionKind.MemberLike && | ||
| isClassLikeMemberCompletion(symbol, location)) { | ||
| isClassLikeMemberCompletion(symbol, location) && !hasInitializer(location.parent)) { |
There was a problem hiding this comment.
Seems like you want something more like
location.parent.getChildren().some(child => child.pos > location.end)I don't know if that's the most-optimal code, but it could be better since you could lose a more-specific type annotation, or trivia. For example:
////interface I {
//// prop: string;
////}
////class C implements I {
//// public pr/**/: "foo" | "bar";
////}
Oleksandr Tarasiuk (a-tarasyuk)
requested a review
from Daniel Rosenwasser (DanielRosenwasser)
October 16, 2022 08:30
Gabriela Araujo Britto (gabritto)
approved these changes
Oct 17, 2022
Daniel Rosenwasser (DanielRosenwasser)
approved these changes
Oct 17, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #51170