Skip to content

[Float][Fiber] Fixes incorrect boolean logic around loading states for stylesheets - #27610

Merged
gnoff merged 1 commit into
react:mainfrom
gnoff:fix-loading
Oct 27, 2023
Merged

[Float][Fiber] Fixes incorrect boolean logic around loading states for stylesheets#27610
gnoff merged 1 commit into
react:mainfrom
gnoff:fix-loading

Conversation

@gnoff

@gnoff gnoff commented Oct 27, 2023

Copy link
Copy Markdown
Collaborator

the loading states of stylesheets found in the DOM during preinit should be assumed to be loaded

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Oct 27, 2023
@gnoff
gnoff requested a review from kassens October 27, 2023 15:38
@react-sizebot

Copy link
Copy Markdown

Comparing: 97047a8...7292090

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 175.09 kB 175.09 kB = 54.48 kB 54.47 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 177.21 kB 177.21 kB = 55.16 kB 55.16 kB
facebook-www/ReactDOM-prod.classic.js = 567.70 kB 567.70 kB = 99.96 kB 99.96 kB
facebook-www/ReactDOM-prod.modern.js = 551.56 kB 551.56 kB = 97.05 kB 97.06 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 7292090

@gnoff
gnoff merged commit 3e09c27 into react:main Oct 27, 2023
@gnoff
gnoff deleted the fix-loading branch October 27, 2023 15:50
github-actions Bot pushed a commit that referenced this pull request Oct 27, 2023
…r stylesheets (#27610)

the loading states of stylesheets found in the DOM during preinit should
be assumed to be loaded

DiffTrain build for [3e09c27](3e09c27)
gnoff added a commit to gnoff/next.js that referenced this pull request Oct 30, 2023
ijjk pushed a commit to vercel/next.js that referenced this pull request Oct 30, 2023
Update React from 8c8ee9ee6 to 0c6348758

- react/react#27627
- react/react#27624
- react/react#27610
- react/react#27592
- react/react#27593
- react/react#27588
- react/react#27591
- react/react#27587

Update @types/react to 18.2.33
Update @types/react-dom to 18.2.14
EdisonVan pushed a commit to EdisonVan/react that referenced this pull request Apr 15, 2024
…r stylesheets (react#27610)

the loading states of stylesheets found in the DOM during preinit should
be assumed to be loaded
bigfootjon pushed a commit that referenced this pull request Apr 18, 2024
…r stylesheets (#27610)

the loading states of stylesheets found in the DOM during preinit should
be assumed to be loaded

DiffTrain build for commit 3e09c27.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed React Core Team Opened by a member of the React Core Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants