Fix error in resumable upload handler - #312
Merged
Merged
Conversation
googlebot
added
the
cla: yes
Contributor
|
@matthewayne it would be great if you could also update the test cases to cover this situation. |
bjwatson
approved these changes
Dec 2, 2016
bjwatson
left a comment
bjwatson
left a comment
There was a problem hiding this comment.
LGTM. I added a PR description for context.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The client library depends on the range header being in the response when the HTTP response code is 308, but the range header is not present in the response when the server hasn't received any bytes previously. This PR defaults to 0 in that case.