examples: Adds client/server retrying example via service config - #7111
Merged
Conversation
|
|
alexanderscott
force-pushed
the
retrying-example
branch
from
June 10, 2020 06:30
40b5cc3 to
87f4770
Compare
alexanderscott
force-pushed
the
retrying-example
branch
from
June 10, 2020 06:39
87f4770 to
d85e6f2
Compare
dapengzhang0
left a comment
dapengzhang0
left a comment
Contributor
There was a problem hiding this comment.
Can you also add a session here for retry, similar for hedging example?
alexanderscott
force-pushed
the
retrying-example
branch
from
June 10, 2020 23:11
709dcd1 to
ca99a05
Compare
Contributor
Author
|
@dapengzhang0 added a section to the README. hope it looks ok 👍 |
Contributor
Author
|
any idea why the "Macos" pipeline check could be stuck on "waiting"? I'm unfamiliar with the CI integrations... |
Contributor
Those tests are manually triggered by project owners for external user's PRs. No worries. |
dapengzhang0
added
the
kokoro:run
grpc-kokoro
removed
the
kokoro:run
dapengzhang0
approved these changes
Jun 15, 2020
ejona86
approved these changes
Jun 16, 2020
Member
|
@alexanderscott, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Provides an example HelloWorld GRPC client & server which demos the effect of client retry policy configured to the ManagedChannel via GRPC ServiceConfig.
Retry policy configuration is outlined in its proposal, and this example is very similar to the Hedging Example.
I created this example to prove that client GRPC retry via service config does indeed work (although still marked as experimental). Also wrote an example and tests using client future unary calls, but figure this simple example is sufficient.