Skip to content

xds: perform header matching on concatenated values - #7215

Merged
voidzcy merged 3 commits into
grpc:masterfrom
voidzcy:bugfix/match_headers_with_concatenated_values
Jul 15, 2020
Merged

xds: perform header matching on concatenated values#7215
voidzcy merged 3 commits into
grpc:masterfrom
voidzcy:bugfix/match_headers_with_concatenated_values

Conversation

@voidzcy

@voidzcy voidzcy commented Jul 15, 2020

Copy link
Copy Markdown
Contributor

No description provided.

@voidzcy
voidzcy requested a review from dapengzhang0 July 15, 2020 19:15
Comment thread xds/src/main/java/io/grpc/xds/RouteMatch.java

@dapengzhang0 dapengzhang0 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread xds/src/main/java/io/grpc/xds/RouteMatch.java
@voidzcy
voidzcy merged commit 92f4842 into grpc:master Jul 15, 2020
@dapengzhang0

Copy link
Copy Markdown
Contributor

I think we need backport it.

@voidzcy voidzcy added the TODO:backport PR needs to be backported. Removed after backport complete label Jul 16, 2020
voidzcy added a commit to voidzcy/grpc-java that referenced this pull request Jul 16, 2020
Combine values of header fields with the same key to a comma-separated string before performing header matching.
voidzcy added a commit that referenced this pull request Jul 17, 2020
#7215) (#7225)

Combine values of header fields with the same key to a comma-separated string before performing header matching.
@voidzcy voidzcy removed the TODO:backport PR needs to be backported. Removed after backport complete label Jul 17, 2020
dfawley pushed a commit to dfawley/grpc-java that referenced this pull request Jan 15, 2021
Combine values of header fields with the same key to a comma-separated string before performing header matching.
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jun 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants