Skip to content

fix(chip): descenders are not clipped in label - #26729

Merged
liamdebeasi merged 7 commits into
mainfrom
FW-3397
Feb 3, 2023
Merged

fix(chip): descenders are not clipped in label#26729
liamdebeasi merged 7 commits into
mainfrom
FW-3397

Conversation

@liamdebeasi

@liamdebeasi liamdebeasi commented Feb 3, 2023

Copy link
Copy Markdown
Contributor

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
    • Some docs updates need to be made in the ionic-docs repo, in a separate PR. See the contributing guide for details.
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue URL: resolves #18313

This was introduced in 91f07bc#diff-e8d29e58b24f373931e570269d49620a54c08a2bd52ea213bc407d8072aa329cR30. We set the line-height to 1 on ion-chip. Labels in an item have overflow: hidden set, so descenders were clipped.

What is the new behavior?

  • Removed the explicit line height in chip
  • Added a test

Does this introduce a breaking change?

  • Yes
  • No

Other information

@bolt-new-by-stackblitz

Copy link
Copy Markdown

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions github-actions Bot added the package: core @ionic/core package label Feb 3, 2023
@liamdebeasi
liamdebeasi marked this pull request as ready for review February 3, 2023 17:18
@liamdebeasi
liamdebeasi requested a review from a team as a code owner February 3, 2023 17:18
@liamdebeasi
liamdebeasi merged commit a9e000b into main Feb 3, 2023
@liamdebeasi
liamdebeasi deleted the FW-3397 branch February 3, 2023 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package: core @ionic/core package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: ion-chip descender clipping

3 participants