fix(datetime-button): time-only values are parsed - #26852
Merged
Conversation
|
|
liamdebeasi
marked this pull request as ready for review
February 24, 2023 14:58
liamdebeasi
requested review from
a team,
averyrousseau and
sean-perkins
as code owners
February 24, 2023 14:58
averyrousseau
approved these changes
Feb 27, 2023
sean-perkins
approved these changes
Feb 28, 2023
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
ionic-docsrepo, in a separate PR. See the contributing guide for details.npm run build) was run locally and any changes were pushednpm run lint) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue URL: resolves #26851
ECMAScript uses a simplified ISO 8601 format that does not allow for time-only values (i.e.
22:40). As a result, developers received anInvalid Dateerror when settingvalue="22:40"(or similar time-only value). However, Ionic does allow for passing time-only values so we need to account for this.What is the new behavior?
getLocalizedTimefunction to always have associated date values. These values do not impact the result of this function sinceIntl.DateTimeFormatonly looks at the hour/minute values.Does this introduce a breaking change?
Other information