fix(select): inherit white-space in select-text to allow wrapping - #26973
Merged
Conversation
|
|
13 tasks
Member
Author
|
@liamdebeasi Can you take a look at approving this PR? Same as the other one I just ran the screenshot action. All the screenshots are updated to include the wrapping example. |
liamdebeasi
suggested changes
Mar 17, 2023
Member
Author
|
@liamdebeasi This is ready for another review! I updated to include a test just for the wrapping. |
liamdebeasi
suggested changes
Mar 22, 2023
liamdebeasi
left a comment
Contributor
There was a problem hiding this comment.
Fixes look good! Just a couple clean up items and this is good to merge. Great job!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a recreation of #26914 in order to run our screenshots
Pull request checklist
Please check if your PR fulfills the following requirements:
ionic-docsrepo, in a separate PR. See the contributing guide for details.npm run build) was run locally and any changes were pushednpm run lint) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
Adding
ion-text-wrapto the parention-selectdoes not wrap the valuesIssue URL: #19949
What is the new behavior?
The
.select-textnow inheritswhite-spacewhich allows theion-selectto take on any value forwhite-space, makingion-text-wrapwork as well.Does this introduce a breaking change?