fix(range): knob positions are correct on initial render with custom elements build - #28257
Merged
Conversation
sean-perkins
marked this pull request as ready for review
September 28, 2023 19:12
sean-perkins
requested review from
a team and
liamdebeasi
and removed request for
a team
September 28, 2023 19:13
liamdebeasi
approved these changes
Sep 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: Resolves #25444
What is the current behavior?
In the custom elements build, currently used by React and Vue packages, the range knob can be rendered incorrectly if the value is assigned after the
connectedCallbackbut before the initial render of the component. This is most apparent with the dual knobs implementation in React (referenced issue).This results in the range's value being correct, but the visual representation of the range to be incorrect.
This also causes issues with the custom elements build in the standalone implementation of Ionic's components in Angular. If a range is presented in a modal via a controller, the range will never render with the value that is initially assigned to it.
What is the new behavior?
Does this introduce a breaking change?
Other information
This change needs to be pulled into the Ionic angular standalone work.
Dev-build:
7.4.3-dev.11695926109.13b1266a