fix(menu): do not error if disabled or swipeGesture is changed mid-animation - #28268
Merged
Conversation
liamdebeasi
changed the title
liamdebeasi
marked this pull request as ready for review
October 2, 2023 17:01
averyrousseau
approved these changes
Oct 4, 2023
Contributor
Author
|
I'm holding off on merging until next week to give developers on the linked threads time to test and provide feedback. |
This was referenced Oct 9, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #20092, resolves #19676, resolves #19000
What is the current behavior?
Menu is currently throwing errors because it expects no animations to be running when any state changes happen (such as changing
disabledorswipeGesture).For example, if you set
swipeGesture="false"mid-gesture then the menu will error. Alternatively, if you setdisabled="true"mid-open animation then the menu will error also. This is undesirable because it can cause visual flickering and other undesirable behaviors as noted in the linked threads.What is the new behavior?
disabledis set totruewhile the menu is opening)Does this introduce a breaking change?
Other information
Dev build:
7.4.3-dev.11696264821.1755dd6a