fix(segment): scroll to active segment-button on first load - #28276
Merged
Conversation
added 2 commits
October 3, 2023 12:57
averyrousseau
marked this pull request as ready for review
October 3, 2023 18:18
brandyscarney
approved these changes
Oct 3, 2023
brandyscarney
left a comment
brandyscarney
left a comment
Member
There was a problem hiding this comment.
Tested this out locally - removed the code with the raf and ran the e2e test and confirmed it failed (expected). Also tested out the segment code in the e2e test by running it in the browser and it is scrolling the view to the active segment button and the highlight size is correct. Works great!
liamdebeasi
reviewed
Oct 4, 2023
liamdebeasi
approved these changes
Oct 4, 2023
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #28096
What is the current behavior?
When a segment button is clicked, the segment will auto-scroll to position the newly active button fully in view. However, this behavior does not occur on first load. This means that when a segment is initialized with a
valuecorresponding to an off-screen button, the button will remain off-screen.What is the new behavior?
The same auto-scroll behavior from button click now also occurs on component load.
Does this introduce a breaking change?
Other information