fix(alert): stop Enter keypress for checkboxes - #28279
Merged
Merged
Conversation
thetaPC
marked this pull request as ready for review
October 4, 2023 18:27
thetaPC
requested review from
a team and
brandyscarney
and removed request for
a team
October 4, 2023 18:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: internal
What is the current behavior?
Checkboxes inside the
ion-alertcan toggle state with theEnterkey. This does not follow keyboard navigation specs.What is the new behavior?
Spacekey toggles states on the checkboxes.Enterkey.Does this introduce a breaking change?
Other information
N/A