Skip to content

fix(core): swipe to go back gesture has priority over other horizontal swipe gestures - #28304

Merged
liamdebeasi merged 2 commits into
ionic-team:mainfrom
aeharding:fix-swipe-back-gesture-priority
Oct 9, 2023
Merged

fix(core): swipe to go back gesture has priority over other horizontal swipe gestures#28304
liamdebeasi merged 2 commits into
ionic-team:mainfrom
aeharding:fix-swipe-back-gesture-priority

Conversation

@aeharding

@aeharding aeharding commented Oct 8, 2023 •
edited by liamdebeasi
Loading

Copy link
Copy Markdown
Contributor

Issue number: resolves #28303

What is the current behavior?

  • Swipe back gesture is inconsistently clobbered by ion-item-sliding's gesture.

What is the new behavior?

  • Swipe back gesture now has a higher priority than ion-item-sliding

Does this introduce a breaking change?

  • Yes
  • No

Other information

This patch has been in use in Voyager for the past couple months to great success!

@aeharding
aeharding requested a review from liamdebeasi as a code owner October 8, 2023 00:58
@github-actions github-actions Bot added the package: core @ionic/core package label Oct 8, 2023
@aeharding aeharding changed the title Fix ion item sliding clubbering swipe back gesture Fix ion item sliding clobbering swipe back gesture Oct 8, 2023
@liamdebeasi liamdebeasi changed the title Fix ion item sliding clobbering swipe back gesture fix(core): swipe to go back gesture has priority over other horizontal swipe gestures Oct 9, 2023
liamdebeasi
liamdebeasi reviewed Oct 9, 2023
View reviewed changes

@liamdebeasi liamdebeasi left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. Was able to verify this locally:

main branch
Screen.Recording.2023-10-09.at.10.40.23.AM.mov
Screen.Recording.2023-10-09.at.10.40.52.AM.mov

Comment thread core/src/utils/gesture/swipe-back.ts
liamdebeasi
liamdebeasi approved these changes Oct 9, 2023
View reviewed changes

@liamdebeasi liamdebeasi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@liamdebeasi
liamdebeasi enabled auto-merge October 9, 2023 14:45
@liamdebeasi
liamdebeasi added this pull request to the merge queue Oct 9, 2023
Merged via the queue into ionic-team:main with commit d5f0c77 Oct 9, 2023
@aeharding
aeharding deleted the fix-swipe-back-gesture-priority branch October 9, 2023 15:29
@liamdebeasi liamdebeasi mentioned this pull request Oct 9, 2023
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@liamdebeasi liamdebeasi liamdebeasi approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

package: core @ionic/core package

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

bug: ion-item-sliding inconsistently clobbers page swipe back gesture

2 participants

@aeharding @liamdebeasi