Skip to content

fix(list-header): apply safe area to proper side regardless of direction - #28371

Merged
brandyscarney merged 5 commits into
mainfrom
FW-5175
Oct 25, 2023
Merged

fix(list-header): apply safe area to proper side regardless of direction#28371
brandyscarney merged 5 commits into
mainfrom
FW-5175

Conversation

@brandyscarney

@brandyscarney brandyscarney commented Oct 17, 2023

Copy link
Copy Markdown
Member

Issue number: Internal


What is the current behavior?

The list header adds padding to the "start" side (padding-left in LTR and padding-right in RTL) based on the value of --ion-safe-area-left. It does not account for --ion-safe-area-right at all even though the list header can extend to the right side of the content.

What is the new behavior?

  • The --ion-safe-area-left always applies to the left side of the screen, regardless of direction. This means that in both LTR and RTL it applies as padding-left.
  • Added support for --ion-safe-area-right which applies to padding-right in both LTR and RTL.
  • Adds an e2e test which captures the list header with a button to ensure the proper padding is added for the safe area.

Does this introduce a breaking change?

  • Yes
  • No

Other information

Safe Area Left

mode direction main branch
ios LTR ios-ltr-main ios-ltr-branch
ios RTL ios-rtl-main ios-rtl-branch
md LTR md-ltr-main md-ltr-branch
md RTL md-rtl-main md-rtl-branch

Safe Area Right

mode direction main branch
ios LTR ios-ltr-main ios-ltr-branch
ios RTL ios-rtl-main ios-rtl-branch
md LTR md-ltr-main md-ltr-branch
md RTL md-rtl-main md-rtl-branch

@github-actions github-actions Bot added the package: core @ionic/core package label Oct 17, 2023
@brandyscarney
brandyscarney force-pushed the FW-5175 branch 3 times, most recently from ae53cfb to e898809 Compare October 18, 2023 22:15
@brandyscarney
brandyscarney marked this pull request as ready for review October 19, 2023 14:04
@brandyscarney
brandyscarney requested review from a team and liamdebeasi and removed request for a team October 19, 2023 14:04
Comment thread core/src/components/list-header/test/basic/list-header.e2e.ts
@brandyscarney
brandyscarney added this pull request to the merge queue Oct 25, 2023
Merged via the queue into main with commit f99d530 Oct 25, 2023
@brandyscarney
brandyscarney deleted the FW-5175 branch October 25, 2023 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package: core @ionic/core package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants