fix(list-header): apply safe area to proper side regardless of direction - #28371
Merged
Conversation
2 tasks
brandyscarney
force-pushed
the
FW-5175
branch
3 times, most recently
from
October 18, 2023 22:15
ae53cfb to
e898809
Compare
brandyscarney
force-pushed
the
FW-5175
branch
from
October 18, 2023 22:16
e898809 to
a30392c
Compare
brandyscarney
marked this pull request as ready for review
October 19, 2023 14:04
brandyscarney
requested review from
a team and
liamdebeasi
and removed request for
a team
October 19, 2023 14:04
liamdebeasi
reviewed
Oct 24, 2023
liamdebeasi
approved these changes
Oct 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: Internal
What is the current behavior?
The list header adds padding to the "start" side (
padding-leftin LTR andpadding-rightin RTL) based on the value of--ion-safe-area-left. It does not account for--ion-safe-area-rightat all even though the list header can extend to the right side of the content.What is the new behavior?
--ion-safe-area-leftalways applies to the left side of the screen, regardless of direction. This means that in both LTR and RTL it applies aspadding-left.--ion-safe-area-rightwhich applies topadding-rightin both LTR and RTL.Does this introduce a breaking change?
Other information
Safe Area Left
mainbranchiosLTRiosRTLmdLTRmdRTLSafe Area Right
mainbranchiosLTRiosRTLmdLTRmdRTL