fix(tab-bar): apply safe area to proper side regardless of direction - #28372
Merged
Conversation
brandyscarney
changed the title
brandyscarney
marked this pull request as ready for review
October 18, 2023 15:10
brandyscarney
requested review from
a team and
liamdebeasi
and removed request for
a team
October 18, 2023 15:10
liamdebeasi
reviewed
Oct 19, 2023
2 tasks
liamdebeasi
approved these changes
Oct 25, 2023
liamdebeasi
left a comment
liamdebeasi
left a comment
Contributor
There was a problem hiding this comment.
Good to go once my last comment is addressed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: Internal
What is the current behavior?
The safe area padding (both left and right) swap sides when the app's direction changes from LTR to RTL. The
--ion-safe-area-leftshould always apply to the left side of the device and the--ion-safe-area-rightshould always apply to the right side of the device.What is the new behavior?
padding-leftandpadding-rightDoes this introduce a breaking change?