fix(segment): avoid scrolling webkit bug - #28376
Merged
Merged
Conversation
averyrousseau
approved these changes
Oct 20, 2023
averyrousseau
left a comment
Contributor
There was a problem hiding this comment.
Tested in Chrome, Firefox, and Safari, all on both LTR and RTL. Works like a charm 👍
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 25, 2023
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #28373
🚨 Reviewers: Please test this on Chrome, Firefox, and Safari
What is the current behavior?
The fix in 1167a93 uncovered a WebKit bug where scrolling an element using
scrollIntoViewduring an accelerated transition causes the segment to jump during the transition.scrollIntoViewcan cause parent elements to also scroll, and given that the entering view begins outside the viewport, it's possible this triggered some sort of WebKit bug where it was trying to scroll the element into view.What is the new behavior?
scrollByinstead ofscrollIntoView.scrollBydoes not attempt to scroll parent elements which avoids the WebKit issue.Does this introduce a breaking change?
Other information
Dev build:
7.5.2-dev.11697638908.1f04980a