fix(item-divider): apply safe area to proper side regardless of direction - #28420
Merged
Conversation
mapsandapps
marked this pull request as ready for review
November 2, 2023 15:22
mapsandapps
requested review from
a team and
liamdebeasi
and removed request for
a team
November 2, 2023 15:22
liamdebeasi
approved these changes
Nov 3, 2023
liamdebeasi
left a comment
Contributor
There was a problem hiding this comment.
A few small changes, but otherwise looks good.
| <div slot="helper">Helper</div> | ||
| </ion-item> | ||
|
|
||
| <ion-item-divider> |
Contributor
There was a problem hiding this comment.
Optional: I think it's confusing to add the item-divider to the item tests when item-divider has its own test directory in item-divider/test. I'll defer to you and Brandy though.
Contributor
Author
There was a problem hiding this comment.
My thinking was
- That it would be easier to understand what regression was occurring if Item & Item Divider are in the same test
- It's more efficient to combine them into the same test
- There are other tests in Item that include Item Dividers
but i can move them. It doesn't really matter. 🤷🏻
Co-authored-by: Liam DeBeasi <liamdebeasi@users.noreply.github.com>
Co-authored-by: Brandy Carney <brandyscarney@users.noreply.github.com>
brandyscarney
approved these changes
Nov 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: Internal
What is the current behavior?
The safe area for Item Divider would change sides when the direction changed. e.g., if the safe area padding should be on the left, it would be on the left when the direction was LTR but would be on the right when the direction was RTL. It should always be on the left.
What is the new behavior?
Similar to #28403 but for Item Divider.
Does this introduce a breaking change?
Other information