fix(header): collapsible large title does not flicker when collapse prop not reflected - #28472
Merged
Conversation
…rop is not relfected
liamdebeasi
changed the title
liamdebeasi
marked this pull request as ready for review
November 6, 2023 15:36
liamdebeasi
requested review from
a team and
brandyscarney
and removed request for
a team
November 6, 2023 15:37
brandyscarney
approved these changes
Nov 8, 2023
brandyscarney
left a comment
brandyscarney
left a comment
Member
There was a problem hiding this comment.
Tested this out in the app in the linked issue and it seems to resolve the original issue. Also tested by adding a scrollable list and a translucent header and everything worked well with the dev build.
Co-authored-by: Brandy Carney <brandyscarney@users.noreply.github.com>
3 tasks
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #28466
What is the current behavior?
In #27060 I fixed an issue where the main title would be visible briefly before the collapsible large title a) was configured and b) hid the main title. I accomplished this by using CSS to target
ion-header[collapse="condense"]. However, I failed to account for when the property is not reflected on the host. Some JS frameworks allow the property to remain on the element but some do not.What is the new behavior?
before.mp4
RPReplay_Final1699283941.MP4
Does this introduce a breaking change?
Other information
Dev build:
7.5.4-dev.11699282935.1db450b0