fix(searchbar): cancel icon aligns with back button - #28478
Merged
Conversation
liamdebeasi
changed the title
liamdebeasi
marked this pull request as ready for review
November 6, 2023 22:59
Member
There was a problem hiding this comment.
I took a look at this and I had different results. Using the images in the description, v4 was also slightly misaligned:
I also took a closer look at the padding used in this PR (8px) because it looked off just barely, and found that using 9px seems to get us closer in alignment:
Let me know if you are seeing something different or if you need a higher res of my last image.
Co-authored-by: Brandy Carney <brandyscarney@users.noreply.github.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #28468
What is the current behavior?
The cancel button in the searchbar used to align with the back button, but that behavior gradually regressed between Ionic v4 and Ionic v7.
What is the new behavior?
ion-back-buttonicon was 24px. This caused the icons to never align even with 9px. (This should cause a few additional diffs)Note that in v4 the alignment was slightly off. It was fixed in v5, but then broke in v6 and remained unchanged in v7 (until now).
Does this introduce a breaking change?
Other information
Dev build:
7.5.4-dev.11699310489.151b2717