fix(datetime): updating value with min scrolls to new value - #28549
Merged
Conversation
liamdebeasi
marked this pull request as ready for review
November 16, 2023 21:20
liamdebeasi
requested review from
averyrousseau and
sean-perkins
as code owners
November 16, 2023 21:20
averyrousseau
approved these changes
Nov 16, 2023
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #28548
What is the current behavior?
Datetime was not scrolling at all when the
valueprop was changed programmatically. This was due to some logic we had incomponentDidRenderto work around a WebKit bug which was causing the scroll position to be moved back to where it was prior to setting thevalueprop. This caused the scroll position to never move.What is the new behavior?
valueis updated programmatically even ifminis set.Does this introduce a breaking change?
Other information
Dev build:
7.5.6-dev.11700169088.140f3e6aCo-authored-by: amandaejohnston amandaejohnston@users.noreply.github.com