fix(angular): overlays are defined when using standalone controllers - #28560
Merged
Conversation
liamdebeasi
changed the title
liamdebeasi
marked this pull request as ready for review
November 20, 2023 15:06
3 tasks
sean-perkins
approved these changes
Nov 20, 2023
sean-perkins
left a comment
sean-perkins
left a comment
Contributor
There was a problem hiding this comment.
Changes look good & tested against the reproduction in production mode and the overlays rendered correctly.
Nice work!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #28385
What is the current behavior?
Overlay controllers do not register their respective overlays components. This results in the overlay not appearing.
What is the new behavior?
defineCustomElementfor their respective overlay component to ensure the component is loaded/registered.Does this introduce a breaking change?
Other information
Dev build:
7.5.6-dev.11700492285.1581ed02