feat(radio): add shadow part for label - #28607
Merged
Merged
Conversation
averyrousseau
approved these changes
Dec 1, 2023
averyrousseau
left a comment
averyrousseau
left a comment
Contributor
There was a problem hiding this comment.
I tested TalkBack and VoiceOver, but I couldn't find any behavior differences either, so I think we're good 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: Part of #28300
What is the current behavior?
Developers are unable to adjust margin, width, etc. of the radio label
What is the new behavior?
Does this introduce a breaking change?
Other information
As part of this work, I investigated moving
pointer-events: noneup the DOM tree so developers wouldn't be able to override it with the shadow part. In my testing, I was unable to see any difference in behavior with vs withoutpointer-events: none. Therefore, I removed it entirely.