fix(react): router creates new view instances of parameterized routes - #28616
Merged
Conversation
aeharding
approved these changes
Dec 1, 2023
aeharding
left a comment
Contributor
There was a problem hiding this comment.
yeeted this into production for Voyager last night at it's working perfectly :)
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: Resolves #26524
Definitions
Parameterized routes: A route that includes one or more variables in the path segments, such as
/form/:index.What is the current behavior?
When an application routes from a parameterized route, to an intermediary route, to the same parameterized route, but with a different value/url, Ionic's routing logic is incorrectly reusing the view item from the first instance of the parameterized route instead of calculating that the matched path is different. This results in the wrong view item being recycled and rendered.
Another way of representing it:
/form/0which resolvesFormPage0into the form and submits the form/link, which resolvesLinkPage/form/1, which resolvesFormPageFormPageit is reusing the instance ofFormPagefrom/form/0which includes the form having0in the input.This is not expected or desired.
What is the new behavior?
Kapture.2023-11-30.at.15.05.04.mp4
Does this introduce a breaking change?
Other information
Dev-build:
7.5.8-dev.11701383555.17254408