Skip to content

fix(angular): add missing menu controller methods - #28618

Merged
thetaPC merged 3 commits into
mainfrom
FW-731
Dec 5, 2023
Merged

fix(angular): add missing menu controller methods#28618
thetaPC merged 3 commits into
mainfrom
FW-731

Conversation

@thetaPC

@thetaPC thetaPC commented Dec 1, 2023

Copy link
Copy Markdown
Contributor

Issue number: resolves #20053


What is the current behavior?

There are a few methods that that are missing for the menu in the Angular packages. This leads to users to not being able to use methods like isAnimating().

What is the new behavior?

  • The missing methods have been added by implementing MenuControllerI.

Does this introduce a breaking change?

  • Yes
  • No

Other information

Dev build: 7.5.8-dev.11701461830.1be851fd

@github-actions github-actions Bot added the package: angular @ionic/angular package label Dec 1, 2023
@thetaPC
thetaPC marked this pull request as ready for review December 1, 2023 21:23
@thetaPC
thetaPC requested a review from sean-perkins as a code owner December 1, 2023 21:23
@thetaPC
thetaPC requested a review from a team December 1, 2023 21:24
Comment thread packages/angular/common/src/providers/menu-controller.ts Outdated
@thetaPC
thetaPC requested a review from sean-perkins December 5, 2023 00:13
Comment thread packages/angular/common/src/providers/menu-controller.ts Outdated
@thetaPC
thetaPC requested a review from sean-perkins December 5, 2023 17:42

@sean-perkins sean-perkins left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@thetaPC
thetaPC added this pull request to the merge queue Dec 5, 2023
Merged via the queue into main with commit 7871b56 Dec 5, 2023
@thetaPC
thetaPC deleted the FW-731 branch December 5, 2023 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package: angular @ionic/angular package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: angular, isAnimating() not defined on menu controller provider

2 participants