fix(refresher): native ios refresher works on iPadOS - #28620
Merged
Conversation
Co-authored-by: Sean Perkins <sean-perkins@user.noreply.github.com>
liamdebeasi
marked this pull request as ready for review
December 20, 2023 16:16
liamdebeasi
requested review from
a team and
averyrousseau
and removed request for
a team
December 20, 2023 16:16
averyrousseau
approved these changes
Dec 20, 2023
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #28617
What is the current behavior?
We currently check to see if
webkitOverflowScrollingis supported on the refresher's style object in order to enable to native iOS refresher. This works well for iOS, but it does not work for iPadOS. This is because this property was removed in iPadOS 13: https://developer.apple.com/documentation/safari-release-notes/safari-13-release-notesAs a result, the native iOS refresher does not activate on iPadOS.
What is the new behavior?
webkitOverflowScrollingmay be removed on iOS in the future too since it was already removed on iPadOS. As a result, I implemented a solution that avoids checking this.CSS.supportscheck is required because otherwise the native iOS refresher would be activated in an emulated environment such as Chrome dev tools because the user agent is spoofed. Theapple-pay-logo-blacknamed image is only supported on Apple devices.Risks:
apple-pay-logo-blacknamed image in the future. However, we currently use this check elsewhere in Ionic too and it has worked well:ionic-framework/core/src/components/datetime/datetime.ios.scss
Line 177 in 60303aa
Does this introduce a breaking change?
Other information
Dev build:
7.5.8-dev.11703088210.14a72b83Co-authored-by: Sean Perkins sean-perkins@users.noreply.github.com