fix(react): use custom animation when going back after a replace - #28674
Merged
Conversation
liamdebeasi
marked this pull request as ready for review
December 8, 2023 15:26
averyrousseau
approved these changes
Dec 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #28673
What is the current behavior?
When reviewing #28671 I noticed a bug where the custom animation was not used when going back after a replace.
handleNavigatewill override whatever is inincomingRouteParams. Since we were passingrouteAnimation(which isundefined), it was overriding the animation we set inhandleNavigateBack.What is the new behavior?
routeAnimationis no longer overriddenDoes this introduce a breaking change?
Other information
Dev build:
7.6.1-dev.11702048520.13c82dad