fix(input, textarea, select): reduce padding on slotted buttons - #28676
Merged
Conversation
averyrousseau
marked this pull request as ready for review
December 8, 2023 19:54
averyrousseau
requested review from
a team and
sean-perkins
and removed request for
a team
December 8, 2023 19:54
brandyscarney
self-requested a review
December 12, 2023 16:00
thetaPC
requested changes
Dec 12, 2023
added 2 commits
December 12, 2023 15:16
averyrousseau
requested review from
thetaPC
and removed request for
sean-perkins
December 12, 2023 21:21
brandyscarney
approved these changes
Dec 13, 2023
brandyscarney
approved these changes
Dec 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: N/A
What is the current behavior?
Buttons slotted in the start/end slots of input, textarea, or select have a lot of excess padding that can cause them to look misaligned from other pieces such as the control's label, especially when using
fill="clear".What is the new behavior?
Padding removed, and a border radius added so that non-clear buttons as well as the focus state on clear buttons still look okay. Existing screenshot tests have also been updated to include buttons (non-clear ones so you can see the border radius in the screenshots).
Let me know if you think this should go on a feature branch instead. I chose
mainbecause the current experience looks somewhat broken and we just did a minor release recently, but this could be considered a notable enough behavior change.Does this introduce a breaking change?
Other information