fix(item): label does not expand indefinitely - #28700
Merged
Merged
Conversation
liamdebeasi
marked this pull request as ready for review
December 13, 2023 20:25
liamdebeasi
enabled auto-merge
December 13, 2023 20:37
brandyscarney
approved these changes
Dec 13, 2023
brandyscarney
left a comment
brandyscarney
left a comment
Member
There was a problem hiding this comment.
This looks good but should we put this in the item test since it only applies when a label is inside of an item? I am good with either way though!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: N/A
What is the current behavior?
While working on an unrelated task, I noticed the list items in the list starter app run off the page. This is due to the text wrapping behavior in v7.6 where we allows the labels to grow/shrink. However, we do not set a limit on how much they can grow. This means that child elements inside of
ion-labelwith long text can cause the label container to grow indefinitely.What is the new behavior?
Does this introduce a breaking change?
Other information
Dev build:
7.6.1-dev.11702498225.1ad6eda6