fix(refresher): mode property can be used in typescript - #28717
Merged
Conversation
Contributor
|
wow that was fast! 🚀 |
Contributor
Author
|
This will only be an Ionic 7 fix. We only back port fixes to Ionic 6 for those who have an "Extended Support" plan with Ionic: https://ionicframework.com/docs/reference/support#framework-maintenance-and-support-status |
liamdebeasi
marked this pull request as ready for review
December 18, 2023 15:56
liamdebeasi
requested review from
a team,
sean-perkins and
thetaPC
as code owners
December 18, 2023 15:56
liamdebeasi
enabled auto-merge
December 18, 2023 15:57
Closed
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #28716
What is the current behavior?
All components that have per-mode stylesheets can have their mode adjusted by setting
modeon the component. We use thesetModefunction to determine which mode to use on the component:ionic-framework/core/src/global/ionic-global.ts
Line 75 in 516b844
While this works on refresher, it is missing the
virtualPropjsdoc comment which causes it to not have the appropriate type information. As a result, when developers try to use a JS binding formode, they will get compilation errors.What is the new behavior?
Does this introduce a breaking change?
Other information
I am considering this a bug fix instead of a feature. In non-TypeScript environments you can set
modeonion-refresherand it does change the mode. What's missing here is the type information associated with it.Dev build:
7.6.2-dev.11702914017.1ae72da5