fix(list): remove uneeded border radius from items in inset list - #28830
Merged
Conversation
averyrousseau
marked this pull request as ready for review
January 15, 2024 19:45
averyrousseau
requested review from
liamdebeasi
and removed request for
a team
January 15, 2024 19:45
liamdebeasi
approved these changes
Jan 16, 2024
liamdebeasi
left a comment
liamdebeasi
left a comment
Contributor
There was a problem hiding this comment.
Looks good! I would consider this a fix though since it's removing buggy behavior.
averyrousseau
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: N/A
What is the current behavior?
In MD mode, items in an inset list currently receive their own border radius, separate from the border radius also applied to the inset list itself. The original intent was likely to ensure that the corners of the items don't spill out of the list. However, the item's border radius is no longer needed, for two reasons:
overflow: hiddenset here, so the list's border radius still applies correctly even with the items' border radius removed.What is the new behavior?
Item border radius in inset lists removed.
When testing locally, you may find it useful to increase the MD border radius value here so it's easier to see.
Does this introduce a breaking change?
Other information