fix(datetime): enter closes keyboard when typing time - #28848
Merged
Conversation
liamdebeasi
changed the title
liamdebeasi
marked this pull request as ready for review
January 17, 2024 22:04
liamdebeasi
requested review from
a team and
averyrousseau
and removed request for
a team
January 17, 2024 22:04
averyrousseau
left a comment
averyrousseau
left a comment
Contributor
There was a problem hiding this comment.
Tested on my actual Android phone and works as written, just had a question about the strategy.
averyrousseau
approved these changes
Jan 18, 2024
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Jan 18, 2024
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #28325
What is the current behavior?
When typing the time into the date picker pressing "Enter" does not close the on-screen keyboard.
What is the new behavior?
Does this introduce a breaking change?
Other information
Test:
src/components/datetime/test/basicDev build:
7.6.6-dev.11705528328.1ef5e17b