Skip to content

fix(radio): persist checked state when items are updated in radio-group - #29457

Merged
thetaPC merged 3 commits into
mainfrom
issue-29442
May 6, 2024
Merged

fix(radio): persist checked state when items are updated in radio-group#29457
thetaPC merged 3 commits into
mainfrom
issue-29442

Conversation

@thetaPC

@thetaPC thetaPC commented May 3, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Issue number: resolves #29442

What is the current behavior?

The state does not stay consistent when the data used to render the radios are updated.

What is the new behavior?

  • The state updates after the component loads, this allows the value to be set after the radio is rendered.

Does this introduce a breaking change?

  • Yes
  • No

Other information

Dev build: 8.1.1-dev.11714760012.1eab947e

@vercel

vercel Bot commented May 3, 2024 •
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ionic-framework ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 6, 2024 4:04pm

@github-actions github-actions Bot added the package: core @ionic/core package label May 3, 2024
@thetaPC
thetaPC marked this pull request as ready for review May 3, 2024 19:59
@thetaPC
thetaPC requested a review from a team as a code owner May 3, 2024 19:59
@thetaPC
thetaPC requested a review from sean-perkins May 3, 2024 19:59
sean-perkins
sean-perkins suggested changes May 6, 2024
View reviewed changes

@sean-perkins sean-perkins left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor docs wording adjustment.

Comment thread core/src/components/radio/radio.tsx Outdated
@thetaPC @sean-perkins
Update core/src/components/radio/radio.tsx
7aa1ad6 
Co-authored-by: Sean Perkins <13732623+sean-perkins@users.noreply.github.com>
sean-perkins
sean-perkins approved these changes May 6, 2024
View reviewed changes

@sean-perkins sean-perkins left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work 👍

@sean-perkins sean-perkins changed the title refactor(radio): update state in componentDidLoad fix(radio): update state in componentDidLoad May 6, 2024
@thetaPC thetaPC changed the title fix(radio): update state in componentDidLoad fix(radio): persist checked state when items are updated May 6, 2024
@thetaPC thetaPC changed the title fix(radio): persist checked state when items are updated fix(radio): persist checked state when items are updated in radio-group May 6, 2024
@thetaPC
thetaPC enabled auto-merge May 6, 2024 17:18
@thetaPC
thetaPC disabled auto-merge May 6, 2024 17:19
@thetaPC
thetaPC enabled auto-merge May 6, 2024 17:19
@thetaPC
thetaPC added this pull request to the merge queue May 6, 2024
Merged via the queue into main with commit 7ea14ae May 6, 2024
@thetaPC
thetaPC deleted the issue-29442 branch May 6, 2024 18:42
@thetaPC thetaPC mentioned this pull request May 6, 2024
Closed
3 tasks
This was referenced Jun 6, 2024
Closed
Closed
@bdr0id bdr0id mentioned this pull request Jun 15, 2024
Closed
@YoutacRandS-VA YoutacRandS-VA mentioned this pull request Jun 20, 2024
Open
@vinnivitz vinnivitz mentioned this pull request Jun 27, 2024
Closed
@vinnivitz vinnivitz mentioned this pull request Jul 4, 2024
Closed
@vinnivitz vinnivitz mentioned this pull request Jul 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brandyscarney brandyscarney brandyscarney approved these changes
+1 more reviewer
@sean-perkins sean-perkins sean-perkins approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

package: core @ionic/core package

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

bug: ion-radio does not keep checked-state after updating the underlaying object

3 participants

@thetaPC @brandyscarney @sean-perkins