fix(alert): do not overwrite id set in htmlAttributes - #29708
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
sean-perkins
changed the title
mikelhamer
left a comment
mikelhamer
left a comment
There was a problem hiding this comment.
Oops. My commit message is bad here. Should just say something like "eslint fix". I didn't realize doing that also changed other things besides adding the semicolon at first
|
@mikelhamer the individual commit messages will not matter here 👍 the Ionic Framework repository uses squash commits and uses the PR subject line as the title and the body of the PR as the message. |
sean-perkins
left a comment
sean-perkins
left a comment
There was a problem hiding this comment.
The proposed changes function as expected in my testing. Thank you for your contribution to Ionic Framework!
For the dev team: This issue applies to more than the ion-alert. I think to deliver value/resolve the issue experienced by Mikel we could merge this and split the original issue to track the other overlays impacted. Then the dev team could either address those or the community could assist in fixing the remaining overlays.
|
Thank you! I'd be glad to help with the remaining overlays once the original issue has been split. |
3 participants
Issue number: resolves #29704
What is the current behavior?
Setting the id of an alert via htmlAttributes doesn't work due to it being overwritten by the overlay id.
What is the new behavior?
Setting the id of an alert via htmlAttributes works.
Does this introduce a breaking change?
Other information
First time PR, long time fan. Please let me know if I missed any of the contributing guidelines, happy to change anything!