fix(content): allow custom roles and aria attributes to be set on content - #29753
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
thetaPC
requested changes
Aug 7, 2024
thetaPC
approved these changes
Aug 7, 2024
thetaPC
left a comment
Contributor
There was a problem hiding this comment.
LGTM, just realized that there's no issue related to this. So disregard my previous request.
BenOsodrac
approved these changes
Aug 7, 2024
This was referenced Sep 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: N/A
What is the current behavior?
Setting a custom
roleon theion-contentelement does not work.What is the new behavior?
roleproperty to be setDoes this introduce a breaking change?
Other information
To test this PR:
core/directorynpx playwright installif it has not been updated recenlynpm run test.e2e src/components/content/test/a11y/core/src/components/content/content.tsxand run the test againshould allow for custom roletests fail