Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
thetaPC
changed the title
thetaPC
changed the title
thetaPC
marked this pull request as ready for review
November 20, 2024 20:01
thetaPC
requested review from
gnbm and
tanner-reits
and removed request for
gnbm
November 20, 2024 20:01
tanner-reits
approved these changes
Nov 21, 2024
tanner-reits
left a comment
tanner-reits
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Confirmed fix behavior in iOS sim
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #29347
What is the current behavior?
Focusable elements like buttons cannot be accessed within the
ion-headerwhen it's collapsed. They're only accessible once the small title is displayed.What is the new behavior?
aria-hiddenfrom the header toion-title, this aligns with native.Does this introduce a breaking change?
Other information
Dev build:
8.4.1-dev.11732064156.12837790