From 819639e9fdbc3f4c14e5839b2717e93b759f7e64 Mon Sep 17 00:00:00 2001 From: Liam DeBeasi Date: Tue, 7 Feb 2023 16:44:54 +0000 Subject: [PATCH] fix(tap-click): instant activate does not use a setTimeout --- core/src/utils/tap-click/index.ts | 11 ++++++++--- core/src/utils/tap-click/test/tap-click.e2e.ts | 5 ++--- 2 files changed, 10 insertions(+), 6 deletions(-) diff --git a/core/src/utils/tap-click/index.ts b/core/src/utils/tap-click/index.ts index 9bef0d4726c..15a05f4f925 100644 --- a/core/src/utils/tap-click/index.ts +++ b/core/src/utils/tap-click/index.ts @@ -91,12 +91,17 @@ export const startTapClick = (config: Config) => { clearDefers.delete(el); } - const delay = isInstant(el) ? 0 : ADD_ACTIVATED_DEFERS; el.classList.remove(ACTIVATED); - activeDefer = setTimeout(() => { + const callback = () => { addActivated(el, x, y); activeDefer = undefined; - }, delay); + }; + + if (isInstant(el)) { + callback(); + } else { + activeDefer = setTimeout(callback, ADD_ACTIVATED_DEFERS); + } } activatableEle = el; }; diff --git a/core/src/utils/tap-click/test/tap-click.e2e.ts b/core/src/utils/tap-click/test/tap-click.e2e.ts index 4a8eb46b5b4..f4e501c7a2a 100644 --- a/core/src/utils/tap-click/test/tap-click.e2e.ts +++ b/core/src/utils/tap-click/test/tap-click.e2e.ts @@ -1,8 +1,7 @@ import { expect } from '@playwright/test'; import { test } from '@utils/test/playwright'; -// TODO FW-3010 -test.describe.skip('tap click utility', () => { +test.describe('tap click utility', () => { test.beforeEach(({ skip }) => { skip.rtl(); skip.mode('ios'); @@ -10,7 +9,7 @@ test.describe.skip('tap click utility', () => { test('it should apply activated class when clicking element', async ({ page }) => { await page.setContent(` - + `);