[charts] Remove usage of focus outline for item highlight#19856
Merged
Conversation
|
Deploy preview: https://deploy-preview-19856--material-ui-x.netlify.app/ Updated pages: Bundle size report
|
github-actions
Bot
added
the
PR: out-of-date
Contributor
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
Bot
removed
the
PR: out-of-date
CodSpeed Performance ReportMerging #19856 will not alter performanceComparing Summary
Footnotes |
alexfauquette
added
the
type: enhancement
JCQuintas
reviewed
Dec 9, 2025
Comment on lines
+93
to
+95
| // import { FocusedBar } from '@mui/x-charts/BarChart'; | ||
| import { LineFocusedMark } from '@mui/x-charts/LineChart'; | ||
| import { ScatterFocusedMark } from '@mui/x-charts/ScatterChart'; |
Member
There was a problem hiding this comment.
Should we follow the same pattern on all focused mark?
Suggested change
| // import { FocusedBar } from '@mui/x-charts/BarChart'; | |
| import { LineFocusedMark } from '@mui/x-charts/LineChart'; | |
| import { ScatterFocusedMark } from '@mui/x-charts/ScatterChart'; | |
| import { FocusedBar } from '@mui/x-charts/BarChart'; | |
| import { FocusedMark } from '@mui/x-charts/LineChart'; | |
| import { FocusedMark } from '@mui/x-charts/ScatterChart'; |
Or
Suggested change
| // import { FocusedBar } from '@mui/x-charts/BarChart'; | |
| import { LineFocusedMark } from '@mui/x-charts/LineChart'; | |
| import { ScatterFocusedMark } from '@mui/x-charts/ScatterChart'; | |
| import { FocusedBar } from '@mui/x-charts/BarChart'; | |
| import { FocusedLineMark } from '@mui/x-charts/LineChart'; | |
| import { FocusedScatterMark } from '@mui/x-charts/ScatterChart'; |
Member
Author
There was a problem hiding this comment.
The other option would be BarFocusedItem to keep consistency with "all bar element start with Bar". But it's less expressive
Member
There was a problem hiding this comment.
It depends on what it aggregates on I suppose. Since this doc is standalone, it feels like we should aggregate on the Focused which is the common ground
JCQuintas
approved these changes
Dec 10, 2025
prakhargupta1
approved these changes
Dec 10, 2025
prakhargupta1
left a comment
prakhargupta1
left a comment
Contributor
There was a problem hiding this comment.
The bar highlight looks quite good now! 👏
All of these refinements might call for a blog post on charts accessibility!
A-s-h-o-k
pushed a commit
to A-s-h-o-k/mui-x
that referenced
this pull request
Dec 14, 2025
1 task
mapache-salvaje
pushed a commit
to mapache-salvaje/mui-x
that referenced
this pull request
Dec 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #19754
I moved all the the focus elements outside of their plot.
The only exception is the pie chart. But to do it properly I will have to move the pie layout computation in the seriesLayout selector