fix(v8): do not ignore failures when running git#809
Merged
Conversation
Also always use `forceRunAsync` because `runAsync` exits the process on error.
Member
Author
|
@nodejs/node-core-utils |
aduh95
approved these changes
May 18, 2024
aduh95
left a comment
aduh95
left a comment
Contributor
There was a problem hiding this comment.
Not sure how to test it, but the code diff looks all right
Member
Author
|
I tested these scenarios locally:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also always use
forceRunAsyncbecauserunAsyncexits the process on error.