feat: add retries to client credential requests - #70
Merged
Conversation
ewanharris
marked this pull request as ready for review
April 3, 2024 19:39
jimmyjames
requested changes
Apr 3, 2024
jimmyjames
left a comment
jimmyjames
left a comment
Contributor
There was a problem hiding this comment.
Looks good - just one suggestion to add wiremock as a test implementation dependency, not an implementation dependency.
jimmyjames
approved these changes
Apr 3, 2024
rhamzeh
approved these changes
Apr 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds retries onto the client credential request.
This is currently untestable in unit tests as the existing HTTP mocking library used can only register one response per URL and this can't be worked around using the
doActionfeature (e.g track number of requests and change response depending on request count), because any request after the first fails.References
Generated from openfga/sdk-generator/pull/333
Review Checklist
main