From d959669f105509ec8f14aa41478e2525d5d3caa0 Mon Sep 17 00:00:00 2001 From: gzzo Date: Wed, 6 Feb 2019 11:32:36 -0500 Subject: [PATCH 1/2] Explicitly state that `activeOpacity` requires `underlayColor` It's clear from https://github.com/facebook/react-native/issues/11834 that the underlying issue won't be fixed, so we should update the documentation so people understand that for `activeOpacity` to work, they need to set `underlayColor`. --- docs/touchablehighlight.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/touchablehighlight.md b/docs/touchablehighlight.md index 63fa0c6e333..d990263e59a 100644 --- a/docs/touchablehighlight.md +++ b/docs/touchablehighlight.md @@ -110,7 +110,7 @@ AppRegistry.registerComponent('App', () => App) ### `activeOpacity` -Determines what the opacity of the wrapped view should be when touch is active. The value should be between 0 and 1. Defaults to 0.85. +Determines what the opacity of the wrapped view should be when touch is active. The value should be between 0 and 1. Defaults to 0.85. Requires `underlayColor` to be set. | Type | Required | | ------ | -------- | From 06b38497fad7f2ed7172288b0efc32b0a13e4451 Mon Sep 17 00:00:00 2001 From: Christoph Nakazawa Date: Thu, 7 Feb 2019 14:01:19 +0000 Subject: [PATCH 2/2] Update touchablehighlight.md --- docs/touchablehighlight.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/touchablehighlight.md b/docs/touchablehighlight.md index d990263e59a..014edbf093d 100644 --- a/docs/touchablehighlight.md +++ b/docs/touchablehighlight.md @@ -110,7 +110,7 @@ AppRegistry.registerComponent('App', () => App) ### `activeOpacity` -Determines what the opacity of the wrapped view should be when touch is active. The value should be between 0 and 1. Defaults to 0.85. Requires `underlayColor` to be set. +Determines what the opacity of the wrapped view should be when touch is active. The value should be between 0 and 1. Defaults to 0.85. Requires `underlayColor` to be set. | Type | Required | | ------ | -------- |