From e1f277056a919d2a9a7f3d3af44c5b81ddf67af3 Mon Sep 17 00:00:00 2001 From: Christian Falch Date: Thu, 2 Oct 2025 08:14:27 -0700 Subject: [PATCH 1/2] Improve logging functions (#53976) Summary: This change remove some unnecessary logs and improve the logging functions for the prebuilds ## Changelog: [IOS] [CHANGED] - Updated logging functions for prebuilds Pull Request resolved: https://github.com/facebook/react-native/pull/53976 Test Plan: Run: ``` RCT_USE_RN_DEP=1 RCT_USE_PREBUILT_RNCORE=1 bundle exec pod install ``` Differential Revision: D83481709 Pulled By: cipolleschi --- packages/react-native/scripts/cocoapods/rncore.rb | 10 ++++------ .../react-native/scripts/cocoapods/rndependencies.rb | 10 +++------- 2 files changed, 7 insertions(+), 13 deletions(-) diff --git a/packages/react-native/scripts/cocoapods/rncore.rb b/packages/react-native/scripts/cocoapods/rncore.rb index 7108f147cf1d..b9d394f91425 100644 --- a/packages/react-native/scripts/cocoapods/rncore.rb +++ b/packages/react-native/scripts/cocoapods/rncore.rb @@ -66,7 +66,6 @@ def self.setup_rncore(react_native_path, react_native_version) rncore_log("No prebuilt artifacts found, reverting to building from source.") end rncore_log("Building from source: #{@@build_from_source}") - rncore_log("Source: #{self.resolve_podspec_source()}") end end @@ -89,7 +88,6 @@ def self.resolve_podspec_source() if ENV["RCT_USE_PREBUILT_RNCORE"] == "1" if @@use_nightly - rncore_log("Using nightly tarball") begin return self.podspec_source_download_prebuilt_nightly_tarball(@@react_native_version) rescue => e @@ -210,14 +208,14 @@ def self.rncore_log(message, level = :info) if !Object.const_defined?("Pod::UI") return end - log_message = '[ReactNativeCore] ' + message + log_message = '[ReactNativeCore] ' case level when :info - Pod::UI.puts log_message.green + Pod::UI.puts log_message.green + message when :error - Pod::UI.puts log_message.red + Pod::UI.puts log_message.red + message else - Pod::UI.puts log_message.yellow + Pod::UI.puts log_message.yellow + message end end diff --git a/packages/react-native/scripts/cocoapods/rndependencies.rb b/packages/react-native/scripts/cocoapods/rndependencies.rb index 2717ab09e6b7..3bf2a67a4ba1 100644 --- a/packages/react-native/scripts/cocoapods/rndependencies.rb +++ b/packages/react-native/scripts/cocoapods/rndependencies.rb @@ -75,7 +75,6 @@ def self.resolve_podspec_source() if ENV["RCT_USE_RN_DEP"] && ENV["RCT_USE_RN_DEP"] == "1" if @@use_nightly - rndeps_log("Using nightly tarball") begin return self.podspec_source_download_prebuilt_nightly_tarball(@@react_native_version) rescue => e @@ -84,7 +83,6 @@ def self.resolve_podspec_source() end end - rndeps_log("Using release tarball") begin return self.podspec_source_download_prebuild_release_tarball() rescue => e @@ -204,7 +202,6 @@ def self.download_stable_rndeps(react_native_path, version, configuration) def self.podspec_source_download_prebuilt_nightly_tarball(version) url = nightly_tarball_url(version) - rndeps_log("Using nightly tarball from URL: #{url}") return {:http => url} end @@ -245,14 +242,13 @@ def self.rndeps_log(message, level = :info) if !Object.const_defined?("Pod::UI") return end - log_message = '[ReactNativeDependencies] ' + message case level when :info - Pod::UI.puts log_message.green + Pod::UI.puts '[ReactNativeDependencies] '.green + message when :error - Pod::UI.puts log_message.red + Pod::UI.puts '[ReactNativeDependencies] '.red + message else - Pod::UI.puts log_message.yellow + Pod::UI.puts '[ReactNativeDependencies] '.yellow + message end end From 37ec7f8f472daf380fb65963b4b8d803ec56360a Mon Sep 17 00:00:00 2001 From: Christian Falch Date: Thu, 2 Oct 2025 08:18:44 -0700 Subject: [PATCH 2/2] Update the `source`property to avoid multiple downloads Summary: This commit updates the cocoapods source for RNDependencies so that the source for the package is the locally downloaded file so we don't download twice! ## Changelog: [IOS] [FIXED] - Update the `source`property to avoid multiple downloads Differential Revision: D83753188 Pulled By: cipolleschi --- packages/react-native/scripts/cocoapods/rndependencies.rb | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/packages/react-native/scripts/cocoapods/rndependencies.rb b/packages/react-native/scripts/cocoapods/rndependencies.rb index 3bf2a67a4ba1..33a13c96f4f9 100644 --- a/packages/react-native/scripts/cocoapods/rndependencies.rb +++ b/packages/react-native/scripts/cocoapods/rndependencies.rb @@ -158,9 +158,10 @@ def self.podspec_source_download_prebuild_release_tarball() url = release_tarball_url(@@react_native_version, :debug) rndeps_log("Using tarball from URL: #{url}") - download_stable_rndeps(@@react_native_path, @@react_native_version, :debug) + destinationDebug = download_stable_rndeps(@@react_native_path, @@react_native_version, :debug) download_stable_rndeps(@@react_native_path, @@react_native_version, :release) - return {:http => url} + + return {:http => URI::File.build(path: destinationDebug).to_s } end def self.release_tarball_url(version, build_type)