<%= alternative.name %>
<% if alternative.control? %>
control
<% end %>
+ <% if active_overrides[experiment.name] == alternative.name %>
+ forced for you
+ <% end %>
-
<%= alternative.participant_count %>
-
<%= alternative.unfinished_count %>
-
<%= alternative.completed_count(goal) %>
+
<%= alternative.participants %>
+
<%= alternative.unfinished %>
+
<%= alternative.completed %>
- <%= number_to_percentage(alternative.conversion_rate(goal)) %>%
- <% if experiment.control.conversion_rate(goal) > 0 && !alternative.control? %>
- <% if alternative.conversion_rate(goal) > experiment.control.conversion_rate(goal) %>
-
- +<%= number_to_percentage((alternative.conversion_rate(goal)/experiment.control.conversion_rate(goal))-1) %>%
-
- <% elsif alternative.conversion_rate(goal) < experiment.control.conversion_rate(goal) %>
-
- <%= number_to_percentage((alternative.conversion_rate(goal)/experiment.control.conversion_rate(goal))-1) %>%
-
- <% end %>
- <% end %>
+ <%= number_to_percentage(alternative.conversion_rate) %>%
+ <% if (delta = alternative.conversion_delta) %>"><%= "+" if delta > 0 %><%= number_to_percentage(delta) %>%<% end %>
+ These pin your own visits to a fixed alternative. Other users are unaffected.
+ <% if Split.configuration.store_override %>
+ Your visits are still counted as participants.
+ <% else %>
+ Your visits are not counted as participants, so these experiments can read
+ zero below even though the page rendered an alternative for you.
+ <% end %>
+
+
+
+ <% overrides.sort.each do |experiment_name, alternative_name| %>
+
+
+ <%= h experiment_name %> → <%= h alternative_name.to_s %>
+
+
+
+ <% end %>
+
+
+<% end %>
+
<% if @experiment_names.any? %>
The list below contains all the registered experiments along with the number of test participants, completed and conversion rate currently in the system.
diff --git a/lib/split/experiment.rb b/lib/split/experiment.rb
index d181ee7f..dc67463f 100644
--- a/lib/split/experiment.rb
+++ b/lib/split/experiment.rb
@@ -415,15 +415,6 @@ def calc_time
redis.hget(experiment_config_key, :calc_time).to_i
end
- def jstring(goal = nil)
- js_id = if goal.nil?
- name
- else
- name + "-" + goal
- end
- js_id.gsub("/", "--")
- end
-
def cohorting_disabled?
return @cohorting_disabled if defined?(@cohorting_disabled)
value = redis.hget(experiment_config_key, :cohorting)
diff --git a/lib/split/helper.rb b/lib/split/helper.rb
index 9bda570c..12d2b803 100644
--- a/lib/split/helper.rb
+++ b/lib/split/helper.rb
@@ -127,8 +127,8 @@ def override_alternative_by_params(experiment_name)
def override_alternative_by_cookies(experiment_name)
return unless request_present?
- if request.cookies && request.cookies.key?("split_override")
- experiments = JSON.parse(request.cookies["split_override"]) rescue {}
+ if request.cookies && request.cookies.key?(Split::OVERRIDE_COOKIE_NAME)
+ experiments = JSON.parse(request.cookies[Split::OVERRIDE_COOKIE_NAME]) rescue {}
experiments[experiment_name]
end
end
diff --git a/package.json b/package.json
new file mode 100644
index 00000000..a52dd099
--- /dev/null
+++ b/package.json
@@ -0,0 +1,9 @@
+{
+ "dependencies": {
+ "eslint": "^10.8.0"
+ },
+ "devDependencies": {
+ "@eslint/js": "^10.0.1",
+ "globals": "^17.8.0"
+ }
+}
diff --git a/spec/dashboard/alternative_spec.rb b/spec/dashboard/alternative_spec.rb
new file mode 100644
index 00000000..a22fe933
--- /dev/null
+++ b/spec/dashboard/alternative_spec.rb
@@ -0,0 +1,67 @@
+# frozen_string_literal: true
+
+require "spec_helper"
+require "split/dashboard/experiment"
+
+describe Split::DashboardAlternative do
+ let(:experiment) { Split::ExperimentCatalog.find_or_create("link_color", "blue", "red") }
+ let(:control) { experiment.alternatives[0] }
+ let(:alternative) { experiment.alternatives[1] }
+
+ def view_for(alternative)
+ Split::DashboardAlternative.new(alternative, experiment)
+ end
+
+ describe "#conversion_delta" do
+ before do
+ control.participant_count = 100
+ control.set_completed_count(10)
+ alternative.participant_count = 100
+ end
+
+ it "is nil for the control" do
+ expect(view_for(control).conversion_delta).to be_nil
+ end
+
+ it "is positive when the alternative beats the control" do
+ alternative.set_completed_count(15)
+
+ expect(view_for(alternative).conversion_delta).to be_within(0.0001).of(0.5)
+ end
+
+ it "is negative when the alternative loses to the control" do
+ alternative.set_completed_count(5)
+
+ expect(view_for(alternative).conversion_delta).to eq(-0.5)
+ end
+
+ it "is nil when the rates match" do
+ alternative.set_completed_count(10)
+
+ expect(view_for(alternative).conversion_delta).to be_nil
+ end
+
+ it "is nil when the control has not converted" do
+ control.set_completed_count(0)
+ alternative.set_completed_count(5)
+
+ expect(view_for(alternative).conversion_delta).to be_nil
+ end
+ end
+
+ describe "counts" do
+ before do
+ alternative.participant_count = 10
+ alternative.set_completed_count(4)
+ end
+
+ it "reads the counts once, when built" do
+ view = view_for(alternative)
+ alternative.participant_count = 999
+
+ expect(view.participants).to eq(10)
+ expect(view.completed).to eq(4)
+ expect(view.unfinished).to eq(6)
+ end
+ end
+end
diff --git a/spec/dashboard/experiment_spec.rb b/spec/dashboard/experiment_spec.rb
new file mode 100644
index 00000000..e063a160
--- /dev/null
+++ b/spec/dashboard/experiment_spec.rb
@@ -0,0 +1,77 @@
+# frozen_string_literal: true
+
+require "spec_helper"
+require "split/dashboard/experiment"
+
+describe Split::DashboardExperiment do
+ let(:experiment) { Split::ExperimentCatalog.find_or_create("link_color", "blue", "red") }
+ let(:blue) { experiment.alternatives[0] }
+ let(:red) { experiment.alternatives[1] }
+ let(:view) { Split::DashboardExperiment.new(experiment) }
+
+ describe "#extra_totals" do
+ it "sums columns whose values are all numeric" do
+ blue.record_extra_info("revenue", 10)
+ blue.record_extra_info("clicks", 2)
+ red.record_extra_info("revenue", 5)
+ red.record_extra_info("clicks", 3)
+
+ expect(view.extra_totals).to eq("revenue" => 15, "clicks" => 5)
+ end
+
+ it "reports N/A for non-numeric columns" do
+ blue.record_extra_info("note", "first")
+ red.record_extra_info("note", "second")
+
+ expect(view.extra_totals).to eq("note" => "N/A")
+ end
+
+ it "reports N/A when a column mixes numbers with anything else" do
+ blue.record_extra_info("revenue", 10)
+ red.record_extra_info("revenue", "unknown")
+
+ expect(view.extra_totals).to eq("revenue" => "N/A")
+ end
+
+ it "reports N/A when a column has no values at all" do
+ blue.record_extra_info("revenue", nil)
+
+ expect(view.extra_totals).to eq("revenue" => "N/A")
+ end
+
+ it "is empty when no alternative recorded extra info" do
+ expect(view.extra_totals).to eq({})
+ end
+ end
+
+ describe "#extra_columns" do
+ it "unions columns across alternatives in first-seen order" do
+ blue.record_extra_info("b", 1)
+ red.record_extra_info("a", 2)
+ red.record_extra_info("b", 3)
+
+ expect(view.extra_columns).to eq(["b", "a"])
+ end
+ end
+
+ describe "totals" do
+ before do
+ blue.participant_count = 10
+ blue.set_completed_count(1)
+ red.participant_count = 20
+ red.set_completed_count(2)
+ end
+
+ it "sums participants across alternatives" do
+ expect(view.total_participants).to eq(30)
+ end
+
+ it "sums completions across alternatives" do
+ expect(view.total_completed).to eq(3)
+ end
+
+ it "sums unfinished participants across alternatives" do
+ expect(view.total_unfinished).to eq(27)
+ end
+ end
+end
diff --git a/spec/dashboard_helpers_spec.rb b/spec/dashboard_helpers_spec.rb
index 4894db01..290e6238 100644
--- a/spec/dashboard_helpers_spec.rb
+++ b/spec/dashboard_helpers_spec.rb
@@ -40,4 +40,48 @@
end
end
end
+
+ describe "active_overrides" do
+ let(:request) { double(cookies: cookies) }
+
+ context "with no override cookie" do
+ let(:cookies) { {} }
+
+ it "is empty" do
+ expect(active_overrides).to eq({})
+ end
+ end
+
+ context "with an empty override cookie" do
+ let(:cookies) { { "split_override" => "" } }
+
+ it "is empty" do
+ expect(active_overrides).to eq({})
+ end
+ end
+
+ context "with a valid override cookie" do
+ let(:cookies) { { "split_override" => '{"link_color":"blue"}' } }
+
+ it "returns the experiment to alternative mapping" do
+ expect(active_overrides).to eq("link_color" => "blue")
+ end
+ end
+
+ context "with a malformed override cookie" do
+ let(:cookies) { { "split_override" => "not json" } }
+
+ it "is empty rather than raising" do
+ expect(active_overrides).to eq({})
+ end
+ end
+
+ context "with a cookie holding JSON that is not an object" do
+ let(:cookies) { { "split_override" => '["link_color"]' } }
+
+ it "is empty" do
+ expect(active_overrides).to eq({})
+ end
+ end
+ end
end
diff --git a/spec/dashboard_spec.rb b/spec/dashboard_spec.rb
index 3d95c8a5..d0156fbf 100644
--- a/spec/dashboard_spec.rb
+++ b/spec/dashboard_spec.rb
@@ -133,6 +133,86 @@ def link(color)
end
end
+ describe "overrides banner" do
+ def force(experiment_name, alternative_name)
+ post "/force_alternative?experiment=#{experiment_name}", alternative: alternative_name
+ end
+
+ it "is hidden when this browser has no overrides" do
+ experiment
+ get "/"
+
+ expect(last_response.body).to_not include("Overrides active in this browser")
+ end
+
+ it "lists each forced experiment once one is set" do
+ force(experiment.name, "blue")
+ get "/"
+
+ expect(last_response.body).to include("Overrides active in this browser")
+ expect(last_response.body).to include("#{experiment.name} → blue")
+ end
+
+ it "warns that overridden visits are not counted" do
+ force(experiment.name, "blue")
+ get "/"
+
+ expect(last_response.body).to include("not counted")
+ end
+
+ it "flags the forced alternative on the experiment itself" do
+ force(experiment.name, "blue")
+ get "/"
+
+ expect(last_response.body).to include("Override:blue")
+ expect(last_response.body).to include("forced for you")
+ end
+
+ it "keeps overrides for other experiments when clearing one" do
+ other = Split::ExperimentCatalog.find_or_create("other_experiment", "small", "large")
+ force(experiment.name, "blue")
+ force(other.name, "small")
+
+ post "/clear_override", experiment: experiment.name
+ get "/"
+
+ expect(last_response.body).to_not include("#{experiment.name} →")
+ expect(last_response.body).to include("#{other.name} → small")
+ end
+
+ it "drops the banner once the last override is cleared" do
+ force(experiment.name, "blue")
+
+ post "/clear_override", experiment: experiment.name
+ get "/"
+
+ expect(last_response.body).to_not include("Overrides active in this browser")
+ end
+
+ it "clears every override at once" do
+ other = Split::ExperimentCatalog.find_or_create("other_experiment", "small", "large")
+ force(experiment.name, "blue")
+ force(other.name, "small")
+
+ post "/clear_overrides"
+ get "/"
+
+ expect(last_response.body).to_not include("Overrides active in this browser")
+ end
+
+ it "starts counting the visitor as a participant once cleared" do
+ force(experiment.name, "blue")
+ get "/my_experiment?experiment=#{experiment.name}"
+ expect(last_response.body).to include("blue")
+ expect(experiment.participant_count).to eq(0)
+
+ post "/clear_overrides"
+ get "/my_experiment?experiment=#{experiment.name}"
+
+ expect(experiment.participant_count).to eq(1)
+ end
+ end
+
describe "index page" do
context "with winner" do
before { experiment.winner = "red" }
@@ -306,4 +386,53 @@ def link(color)
expect(last_response).to be_ok
end
+
+ context "confidence toggle classes" do
+ it "gives each experiment its own index" do
+ Split::ExperimentCatalog.find_or_create("link_color", "blue", "red")
+ Split::ExperimentCatalog.find_or_create("button_size", "small", "big")
+
+ get "/"
+
+ expect(last_response.body).to include('id="dropdown-experiment-0"')
+ expect(last_response.body).to include('id="dropdown-experiment-1"')
+ end
+
+ it "gives each goal of an experiment its own index" do
+ experiment_with_goals
+
+ get "/"
+
+ expect(last_response.body).to include('id="dropdown-experiment-0-0"')
+ expect(last_response.body).to include('id="dropdown-experiment-0-1"')
+ end
+
+ it "keeps the toggle classes and options in sync" do
+ experiment
+
+ get "/"
+
+ expect(last_response.body).to include('